Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"invalid value / unknown config name: dm1" when give empty tls config #7384

Closed
D3Hunter opened this issue Oct 17, 2022 · 1 comment · Fixed by #7451
Closed

"invalid value / unknown config name: dm1" when give empty tls config #7384

D3Hunter opened this issue Oct 17, 2022 · 1 comment · Fixed by #7451
Labels
area/dm Issues or PRs related to DM. severity/minor type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

What did you do?

  • start job with target config:
target-database:
  host: aaxxxxx
  port: 4000
  user: root
  password: "123456"
  max-allowed-packet: null
  session: {}
  security:
    ssl-ca: ""
    ssl-cert: ""
    ssl-key: ""
    cert-allowed-cn: []
    ssl-ca-bytes: []
    ssl-key-bytes: []
    ssl-cert-bytes: []
    ssl-ca-base64: ""
    ssl-key-base64: ""
    ssl-cert-base64: ""
  • job fail with "invalid value / unknown config name: dm1"

caused by this line, it returns nil, nil on empty tls

tlsConfig, err := util.NewTLSConfig(

What did you expect to see?

skip tls cert or report tls cert error

What did you see instead?

empty config

Versions of the cluster

current master branch

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. severity/minor area/dm Issues or PRs related to DM. labels Oct 17, 2022
@D3Hunter
Copy link
Contributor Author

@liumengya94 ptal

/cc @lance6716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant