Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiCDC version check should skip TiFlash instances #7744

Closed
overvenus opened this issue Nov 30, 2022 · 0 comments · Fixed by #7746
Closed

TiCDC version check should skip TiFlash instances #7744

overvenus opened this issue Nov 30, 2022 · 0 comments · Fixed by #7746
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@overvenus
Copy link
Member

What did you do?

Run 6.1.0 TiCDC on a 6.1.0 TiDB cluster, then hotfix TiFlash with a 6.4.0 release.

We can't create changefeeds due to the error:

Error: [CDC:ErrVersionIncompatible]version is incompatible: TiKV 6.4.0 is not supported, the maximum compatible version is 6.2.0-alpha

What did you expect to see?

No error, TiCDC version check should skip TiFlash.

What did you see instead?

Error.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

v6.1.0

Upstream TiKV version (execute tikv-server --version):

v6.1.0

Upstream TiFlash version:

v6.4.0

TiCDC version (execute cdc version):

v6.1.0
@overvenus overvenus added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Nov 30, 2022
@overvenus overvenus mentioned this issue Nov 30, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Nov 30, 2022
@overvenus
version(ticdc): skip checking TiFlash version (#7746)
e7e2894 
close #7744
This was referenced Nov 30, 2022
Closed
Closed
Closed
Closed
Open
Merged
@nongfushanquan nongfushanquan mentioned this issue Dec 7, 2022
Merged
15 tasks
overvenus added a commit to ti-chi-bot/tiflow that referenced this issue Dec 16, 2022
@overvenus
version(ticdc): skip checking TiFlash version (pingcap#7746)
da904da 
close pingcap#7744

Signed-off-by: Neil Shen <overvenus@gmail.com>
ti-chi-bot added a commit that referenced this issue Dec 21, 2022
@ti-chi-bot
version(ticdc): skip checking TiFlash version (#7746) (#7758)
147f25b 
close #7744
@nongfushanquan nongfushanquan mentioned this issue Feb 3, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

version(ticdc): skip checking TiFlash version overvenus/ticdc
1 participant
@overvenus