Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mounter(ticdc): fix truncate table partition cause mounter failed issue (#10528) #10538

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10528

What problem does this PR solve?

Issue Number: close #10522

What is changed and how it works?

like truncate table logic, when a table partition is truncated , CDC should add this partition ID to the memory map, then get a key encoded by this partition ID, mounted should ignore it, otherwise mourner will failed to decode the key.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 23, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 23, 2024
@CharlesCheung96
Copy link
Contributor

/retest

@sdojjy
Copy link
Member

sdojjy commented Jan 24, 2024

/retest-required

2 similar comments
@sdojjy
Copy link
Member

sdojjy commented Jan 24, 2024

/retest-required

@sdojjy
Copy link
Member

sdojjy commented Jan 24, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2024
@sdojjy
Copy link
Member

sdojjy commented Jan 24, 2024

/test verify

@sdojjy
Copy link
Member

sdojjy commented Jan 24, 2024

/retest-required

@sdojjy
Copy link
Member

sdojjy commented Jan 24, 2024

/test cdc-integration-mysql-test

@sdojjy sdojjy added the priority/P1 The issue has P1 priority. label Jan 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-mysql-test bfb0a1d link unknown /test cdc-integration-mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdojjy
Copy link
Member

sdojjy commented Jan 24, 2024

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot merged commit 44c9d4d into pingcap:release-6.5 Jan 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm priority/P1 The issue has P1 priority. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants