kv (ticdc): Improve the codebase of kvClient. #10585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
asddongmen
removed
the
affect-ticdc-config-docs
ti-chi-bot
bot
added
the
size/XL
|
It is no need to merge this PR into master branch. |
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
affect-ticdc-config-docs
asddongmen
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Feb 7, 2024
sdojjy
approved these changes
Feb 7, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/retest |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10585 +/- ##
================================================
+ Coverage 57.5843% 57.7515% +0.1672%
================================================
Files 849 849
Lines 125984 126355 +371
================================================
+ Hits 72547 72972 +425
+ Misses 48007 47951 -56
- Partials 5430 5432 +2 |
CharlesCheung96
approved these changes
Feb 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Feb 18, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
the
needs-cherry-pick-release-7.1
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Feb 20, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
needs-cherry-pick-release-6.5
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Feb 29, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
removed
the
needs-cherry-pick-release-6.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #10584
What is changed and how it works?
eventFeedStreamstruct to make the code more clear.storeStreamsCachecan only be accessed in one goroutine.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note