-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql(ticdc): remove returned error and modify the log in CheckIsTiDB
#11506
mysql(ticdc): remove returned error and modify the log in CheckIsTiDB
#11506
Conversation
…t from error to warning
CheckIsTiDB
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11506 +/- ##
================================================
+ Coverage 57.4511% 57.7083% +0.2572%
================================================
Files 851 851
Lines 126431 127063 +632
================================================
+ Hits 72636 73326 +690
+ Misses 48384 48331 -53
+ Partials 5411 5406 -5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, hongyunyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/check-issue-triage-complete |
/pull-cdc-integration-kafka-test |
/test dm-integration-test |
/test cdc-integration-kafka-test |
1 similar comment
/test cdc-integration-kafka-test |
What problem does this PR solve?
Issue Number: close #11505
What is changed and how it works?
Description:
This PR refactors the
CheckIsTiDB
function in response to internal discussions. Previously, the function returned anerror
which was not necessary, as the external callers should not care about the error of theCheckIsTiDB
function due to #11213.Changes:
error
return type fromCheckIsTiDB
.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note