Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mounter(ticdc): calculate raw bytes checksum by using handle (#11720) #11730

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11720

What problem does this PR solve?

Issue Number: close #11713

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

none

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 28 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@5a10c36). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 59.6041% <0.0000%> (?)
dm 50.0673% <0.0000%> (?)
engine 53.2336% <0.0000%> (?)
Flag Coverage Δ
unit 55.1480% <30.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #11730   +/-   ##
================================================
  Coverage               ?   55.1480%           
================================================
  Files                  ?       1001           
  Lines                  ?     136507           
  Branches               ?          0           
================================================
  Hits                   ?      75281           
  Misses                 ?      55717           
  Partials               ?       5509           

@wk989898
Copy link
Collaborator

wk989898 commented Nov 8, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit d238ea7 into pingcap:release-8.5 Nov 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants