Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: fix owner doesn't clean up stale tasks (#1163) #1184

Merged
merged 4 commits into from
Dec 22, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1163 to release-4.0


What problem does this PR solve?

Fix https://github.com/pingcap/ticdc/issues/1158

  • TiCDC should clean the metadata of a changefeed as thoroughly as possible when removing a changefeed, but it is still possible to leave redundant metadata.
  • Owner should choose whether to filter metadata when using it or clean up redundant data regularly, this PR chooses the second way.

What is changed and how it works?

Owner clean up the stale tasks at the beginning of each run round.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix a bug that outdated metadata could cause the newly created changefeed abnormal.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added type/bugfix This PR fixes a bug. status/ptal Could you please take a look? type/4.0-cherry-pick labels Dec 8, 2020
@ti-srebot ti-srebot added this to the v4.0.10 milestone Dec 8, 2020
@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #1184 (28bdf31) into release-4.0 (ba68bc1) will increase coverage by 0.2059%.
The diff coverage is 30.7692%.

@@                 Coverage Diff                 @@
##           release-4.0      #1184        +/-   ##
===================================================
+ Coverage      39.8383%   40.0442%   +0.2059%     
===================================================
  Files              112        112                
  Lines            11750      11752         +2     
===================================================
+ Hits              4681       4706        +25     
+ Misses            6597       6566        -31     
- Partials           472        480         +8     

@liuzix
Copy link
Contributor

liuzix commented Dec 9, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 9, 2020
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1142

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Dec 22, 2020
@amyangfei amyangfei merged commit 5886032 into pingcap:release-4.0 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants