-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner: fix memory accumulated when owner consume etcd update slow #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
zier-one
reviewed
Dec 18, 2020
Co-authored-by: leoppro <i@leop.pro>
zier-one
reviewed
Dec 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
zier-one
added
needs-cherry-pick-release-4.0
Should cherry pick this PR to release-4.0 branch.
needs-cherry-pick-5.0
labels
Dec 18, 2020
amyangfei
removed
needs-cherry-pick-release-4.0
Should cherry pick this PR to release-4.0 branch.
needs-cherry-pick-5.0
labels
Dec 18, 2020
/run-all-tests |
LGTM |
ti-srebot
approved these changes
Dec 18, 2020
amyangfei
added
type/bug
The issue is confirmed as a bug.
priority/P0
The issue has P0 priority.
labels
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ticdc
Issues or PRs related to TiCDC.
priority/P0
The issue has P0 priority.
severity/critical
status/LGT2
Indicates that a PR has LGTM 2.
type/bug
The issue is confirmed as a bug.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix for a memory accumulated issue in owner
https://github.com/pingcap/ticdc/blob/eed57c94491fd140f0a8a0528acc574bc542bb0b/cdc/owner.go#L1024-L1039
The output channel consume speed (which relays on how often L1035 can be run) may be much slower than the etcd key update frequency, which will lead to data accumulated in etcd watch client
What is changed and how it works?
Ignore position update event if output channel is full, it is safe enough as the owner has a builtin ticker to trigger
o.run
NOTE: this is a release-4.0 quick fix, I will update master/release-5.0 and add test cases later
Check List
Tests
http://<ip>:<port>/debug/pprof/heap
etcd.clientv3
, should be less than5MB
Release note