-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Owner: Fix gcttl bug (#1861) #1872
Owner: Fix gcttl bug (#1861) #1872
Conversation
… current ts - gcttl
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.0 #1872 +/- ##
================================================
Coverage ? 53.8961%
================================================
Files ? 155
Lines ? 16478
Branches ? 0
================================================
Hits ? 8881
Misses ? 6651
Partials ? 946 |
/lgtm |
@asddongmen: Thanks for your review. The bot only counts In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a6af59d
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-tests |
This is an automated cherry-pick of #1861
What problem does this PR solve?
#1839
What is changed and how it works?
Modify the calculation method of MinGCSafePoint (the lower bound of CDC's gcSafePoint)
Before:
MinGCSafePoint = curentTs - gcTTL
After:
MinGCSafePoint = min(curentTs - gcTTL, pdSafePoint)
Check List
Tests
Side effects
Related changes
Release note