-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changefeed: fix add partition in old owner #2205
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2205 +/- ##
===================================================
- Coverage 53.7661% 53.6763% -0.0899%
===================================================
Files 153 163 +10
Lines 15958 17300 +1342
===================================================
+ Hits 8580 9286 +706
- Misses 6475 7035 +560
- Partials 903 979 +76 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
/run-all-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6a5633c
|
/run-leak-tests |
In response to a cherrypick label: new pull request created: #2263. |
What problem does this PR solve?
When TiCDC meets partition table update, the owner diffs the latest partition table information with the memory information, the new added partition and dropped partition should be calculated by
new added = Set(partition table IDs in latest table info) - Set(partition table IDs that TiCDC maintains)
dropped = Set(partition table IDs that TiCDC maintains) - Set(partition table IDs in latest table info)
The new added partition calculation is wrong, the affected version includes >=4.0.2, >=5.0.0.
5.1.0 and master are not affected.
What is changed and how it works?
Should use
oldIDs
as the partition table IDs that TiCDC maintainsCheck List
Tests
Release note