Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compactor: fix data race #3417

Merged
merged 9 commits into from
Nov 15, 2021
Merged

compactor: fix data race #3417

merged 9 commits into from
Nov 15, 2021

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Nov 11, 2021 •
edited
Loading

What problem does this PR solve?

datarace in CI https://ci2.pingcap.net/blue/organizations/jenkins/dm_ghpr_integration_test/detail/dm_ghpr_integration_test/513/pipeline/

What is changed and how it works?

save job.tp before add dml job

Check List

Tests

  • original test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 11, 2021
@GMHDBJD GMHDBJD added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dm Issues or PRs related to DM. labels Nov 11, 2021
Ehco1996
Ehco1996 approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, little suggestion but keep it unchanged is ok

dm/syncer/syncer.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 12, 2021
@GMHDBJD GMHDBJD removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2021
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 15, 2021

/run-leak-test

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 15, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8d81ec7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 15, 2021

/run-dm-integration-test
/run-integration-test
/run-unit-test

@lance6716
Copy link
Contributor

/run-all-tests

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 15, 2021

/run-dm-integration-test

1 similar comment
@Ehco1996
Copy link
Contributor

/run-dm-integration-test

@Ehco1996
Copy link
Contributor

/run-dm-integration-tests

@lance6716
Copy link
Contributor

/run-all-tests

@Ehco1996
Copy link
Contributor

/run-dm-integration-tests

@Ehco1996
Copy link
Contributor

/run-integration-test

@ti-chi-bot
Copy link
Member

@GMHDBJD: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 15, 2021

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 5726c19 into pingcap:master Nov 15, 2021
@lance6716 lance6716 added the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Dec 30, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 30, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4161.

lance6716 pushed a commit that referenced this pull request Dec 30, 2021
@GMHDBJD @lance6716
compactor: fix data race (#3417)
e7e3657
ti-chi-bot added a commit that referenced this pull request Jan 26, 2022
@ti-chi-bot
compactor: fix data race (#3417) (#4161)
33b2219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GMHDBJD @ti-chi-bot @lance6716 @Ehco1996