-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processor,sink(cdc): let sink report resolved ts and do not skip buffer sink flush (#3540) #3561
processor,sink(cdc): let sink report resolved ts and do not skip buffer sink flush (#3540) #3561
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Neil Shen <overvenus@gmail.com>
/merge |
@VelocityLight: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a251cea
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3561 +/- ##
===================================================
+ Coverage 53.7661% 57.1136% +3.3475%
===================================================
Files 153 165 +12
Lines 15958 19582 +3624
===================================================
+ Hits 8580 11184 +2604
- Misses 6475 7338 +863
- Partials 903 1060 +157 |
This is an automated cherry-pick of #3540
What problem does this PR solve?
Revert #3029 and #2617 temporary for resolving #3503.
Cc https://github.com/pingcap/ticdc/issues/3545
Check List
Tests
See #3503
Release note