-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvclient(ticdc): fix kvclient takes too long time to recover (#3612) #3661
kvclient(ticdc): fix kvclient takes too long time to recover (#3612) #3661
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## release-5.1 #3661 +/- ##
================================================
Coverage ? 57.6580%
================================================
Files ? 165
Lines ? 19437
Branches ? 0
================================================
Hits ? 11207
Misses ? 7176
Partials ? 1054 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 669fb2f
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #3612
close #3191
close flaky test in kvclient: #2694 #3302 #2349 #2688 #2747
What problem does this PR solve?
What is changed and how it works?
Reason
We use a tikv node which has about 3k region leaders as our comparison object. After test in normal case and abnormal case, we got follow results:
But, pd and tikv only need about 30s to tag a node 'disconnect' and elect a new leader, so a reasonable timespan to recover is about:
Result
Check List
Tests
Related changes
Release note