Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_api (ticdc): Add some unit tests for HTTP API #3935

Closed
wants to merge 26 commits into from
Closed

http_api (ticdc): Add some unit tests for HTTP API #3935

wants to merge 26 commits into from

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Dec 17, 2021 •
edited
Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

Release note 

 add some unit test for http API.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 17, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 17, 2021
@asddongmen asddongmen added area/ticdc Issues or PRs related to TiCDC. component/status-server Status server component. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Dec 17, 2021
@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

/run-all-tests

This was referenced Dec 17, 2021
Closed
Closed
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2021
@asddongmen
Merge branch 'master' into fix_http_api_get_processor_panic
cb8442c 
# Conflicts:
#	cdc/capture/http_router.go
#	cdc/capture/http_router_test.go
@asddongmen
resolves conflict
4971962
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2021
Rustin170506
Rustin170506 reviewed Dec 21, 2021
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

cdc/model/http_model.go Outdated Show resolved Hide resolved
liuzix
liuzix reviewed Dec 22, 2021
View reviewed changes
Copy link
Contributor

@liuzix liuzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more explanation of your changes in the PR description?

cdc/capture/http_status.go Outdated Show resolved Hide resolved
@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #3935 (39abf5c) into master (3873d39) will decrease coverage by 1.5803%.
The diff coverage is 68.7069%.

Flag Coverage Δ
cdc 59.4254% <68.7069%> (+1.1888%) ⬆️
dm 52.1967% <ø> (-3.8378%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #3935        +/-   ##
================================================
- Coverage   57.0741%   55.4938%   -1.5804%     
================================================
  Files           478        486         +8     
  Lines         56551      59758      +3207     
================================================
+ Hits          32276      33162       +886     
- Misses        20978      23206      +2228     
- Partials       3297       3390        +93

@asddongmen asddongmen removed the needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. label Dec 23, 2021
@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen asddongmen removed the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Dec 23, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2021
@ti-chi-bot
Copy link
Member

@asddongmen: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@asddongmen asddongmen changed the title http_api (ticdc): Fix http api get processor panic and add some unit tests. http_api (ticdc): Add some unit tests for HTTP API Dec 29, 2021
@asddongmen asddongmen closed this Jan 17, 2022
@asddongmen asddongmen deleted the fix_http_api_get_processor_panic branch June 7, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 left review comments

@Ehco1996 Ehco1996 Ehco1996 left review comments

@liuzix liuzix liuzix left review comments

@zhaoxinyu zhaoxinyu zhaoxinyu left review comments

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/status-server Status server component. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@asddongmen @ti-chi-bot @codecov-commenter @zhaoxinyu @liuzix @Ehco1996 @Rustin170506