Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: fix table not found when startTS = 0 #438

Merged
merged 10 commits into from
Apr 8, 2020

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Apr 7, 2020

What problem does this PR solve?

What is changed and how it works?

when startts=0, LoadHistoryDDLJobs function will return a empty jobs array, but we can't receive integrated DDL jobs from DDL Puller

Check List

Tests

  • Unit test
  • Integration test

@zier-one zier-one added the DNM label Apr 7, 2020
@zier-one
Copy link
Contributor Author

zier-one commented Apr 7, 2020

/run-integration-test

@zier-one
Copy link
Contributor Author

zier-one commented Apr 7, 2020

/run-integration-tests

2 similar comments
@zier-one
Copy link
Contributor Author

zier-one commented Apr 7, 2020

/run-integration-tests

@zier-one
Copy link
Contributor Author

zier-one commented Apr 7, 2020

/run-integration-tests

@zier-one
Copy link
Contributor Author

zier-one commented Apr 8, 2020

/run-integraion-tests

@zier-one zier-one changed the title Fix schema bug schema: fix table not found when startTS = 0 Apr 8, 2020
@zier-one zier-one added type/bugfix This PR fixes a bug. component/ddl DDL component. status/ptal Could you please take a look? and removed DNM labels Apr 8, 2020
@zier-one
Copy link
Contributor Author

zier-one commented Apr 8, 2020

/run-integraion-tests

2 similar comments
@zier-one
Copy link
Contributor Author

zier-one commented Apr 8, 2020

/run-integraion-tests

@zier-one
Copy link
Contributor Author

zier-one commented Apr 8, 2020

/run-integraion-tests

@zier-one
Copy link
Contributor Author

zier-one commented Apr 8, 2020

/run-integraion-tests

@zier-one
Copy link
Contributor Author

zier-one commented Apr 8, 2020

/run-integration-tests

cdc/processor.go Outdated Show resolved Hide resolved
@zier-one
Copy link
Contributor Author

zier-one commented Apr 8, 2020

/run-integration-tests

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT1 and removed status/ptal Could you please take a look? labels Apr 8, 2020
@zier-one zier-one merged commit 9508ae4 into pingcap:master Apr 8, 2020
@zier-one zier-one deleted the fix_schema_bug branch April 8, 2020 11:02
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ddl DDL component. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants