Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data inconsistency caused by default value #4446

Closed
wants to merge 7 commits into from
Closed

Fix data inconsistency caused by default value #4446

wants to merge 7 commits into from

Conversation

maxshuang
Copy link
Contributor

What problem does this PR solve?

This is a manual pr merge(#3846 #4224 #3930)

Issue Number: close #3793 #4223 #3929 #3918

Support more data types with default value attribute, and fix potential data inconsistency caused by default value logic

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2022
@maxshuang maxshuang added area/ticdc Issues or PRs related to TiCDC. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 24, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.1@b597887). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.1      #4446   +/-   ##
================================================
  Coverage               ?   62.3676%           
================================================
  Files                  ?        161           
  Lines                  ?      17004           
  Branches               ?          0           
================================================
  Hits                   ?      10605           
  Misses                 ?       5496           
  Partials               ?        903           

@overvenus overvenus added this to the v5.1.4 milestone Jan 25, 2022
@overvenus overvenus added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jan 25, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 7, 2022
@maxshuang maxshuang closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants