unit(dm): add Kill func for unit (#4035) #4604
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #4035
What problem does this PR solve?
Issue Number: close #3737
Root case of #3737
syncer
, syncer will try continue syncing until current trasaction endtiflow/dm/syncer/syncer.go
Line 1411 in abefe57
What is changed and how it works?
kill running subtasks when worker lost the keep-alive with dm-master (both for master offline or worker offline )
add Kill interface func to unit
impleament kill in syncer unit
change
worker.Close
toworker.Stop(graceful bool)
, when ungraceful stop, worker will callkillAllSubTasks
to force stop and this will cancel syncer.Run immediatelyonly when worker lost keepalive unit should call
Kill
Check List
Tests
Code changes
Side effects
Related changes
Release note