Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit(dm): add Kill func for unit (#4035) #4604

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4035

What problem does this PR solve?

Issue Number: close #3737

Root case of #3737

  • when dm-master node offline, dm-worker will lost the keepalive with master
  • dm-worker will use stopWorker to stop running tasks
  • if current running unit is syncer, syncer will try continue syncing until current trasaction end
    tctx.L().Info("received subtask's done")
  • at the same time master online again or another master node beacme leader will try scheduler task to another running worker
  • so there are two workers syncning from same source ,and we may meet duplicate key error

What is changed and how it works?

  • kill running subtasks when worker lost the keep-alive with dm-master (both for master offline or worker offline )

  • add Kill interface func to unit

  • impleament kill in syncer unit

  • change worker.Close to worker.Stop(graceful bool), when ungraceful stop, worker will call killAllSubTasks to force stop and this will cancel syncer.Run immediately

  • only when worker lost keepalive unit should call Kill

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

`fix a bug that multiple worker write for same upstream`.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved area/dm Issues or PRs related to DM. labels Feb 16, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Feb 16, 2022
@Ehco1996
Copy link
Contributor

this cp is rejected closed now

@Ehco1996 Ehco1996 closed this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants