Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api(ticdc): add /api/v2/tso: get tso from pd (Rolled Back) #5635

Merged
merged 20 commits into from
May 31, 2022
Merged

api(ticdc): add /api/v2/tso: get tso from pd (Rolled Back) #5635

merged 20 commits into from
May 31, 2022

Conversation

crelax
Copy link
Contributor

@crelax crelax commented May 30, 2022 •
edited
Loading

TiCDC Open API V2: return tso get from pd

What problem does this PR solve?

Issue Number: close #5586

What is changed and how it works?

Get tso from PD

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

TiCDC Open API V2: return tso get from pd

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • liuzix
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2022
@asddongmen asddongmen requested review from asddongmen and sdojjy and removed request for asddongmen May 30, 2022 04:15
@crelax
Copy link
Contributor Author

crelax commented May 30, 2022

/run-verify-test

@crelax crelax requested a review from liuzix May 30, 2022 10:09
@crelax
Copy link
Contributor Author

crelax commented May 30, 2022

/run-verify-test

@crelax
Copy link
Contributor Author

crelax commented May 30, 2022

/run-integration-test

liuzix
liuzix reviewed May 30, 2022
View reviewed changes
cdc/api/v2/api.go Outdated Show resolved Hide resolved
cdc/api/v2/api.go Show resolved Hide resolved
cdc/api/v2/api.go Outdated Show resolved Hide resolved
cdc/api/v2/api.go Show resolved Hide resolved
@crelax
Copy link
Contributor Author

crelax commented May 30, 2022

/run-verify-test

liuzix
liuzix reviewed May 30, 2022
View reviewed changes
cdc/api/v2/api.go Outdated Show resolved Hide resolved
cdc/api/v2/api.go Outdated Show resolved Hide resolved
@sdojjy
Copy link
Member

sdojjy commented May 31, 2022

please adjust your IDE code format style to fix the lint.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022 •
edited
Loading

Codecov Report

Merging #5635 (e1d6175) into master (fcea4d5) will increase coverage by 0.5527%.
The diff coverage is 57.5837%.

Flag Coverage Δ
cdc 61.9407% <62.1374%> (+0.7926%) ⬆️
dm 52.0170% <29.5774%> (-0.0257%) ⬇️
engine 58.6856% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5635        +/-   ##
================================================
+ Coverage   56.0768%   56.6296%   +0.5527%     
================================================
  Files           535        675       +140     
  Lines         70143      79001      +8858     
================================================
+ Hits          39334      44738      +5404     
- Misses        27078      30055      +2977     
- Partials       3731       4208       +477

liuzix
liuzix reviewed May 31, 2022
View reviewed changes
cdc/api/v2/api_test.go Outdated Show resolved Hide resolved
@crelax
Copy link
Contributor Author

crelax commented May 31, 2022

/run-all-tests

@crelax
Copy link
Contributor Author

crelax commented May 31, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2022
@crelax crelax requested a review from liuzix May 31, 2022 06:37
@crelax
Copy link
Contributor Author

crelax commented May 31, 2022

/run-all-tests

@crelax
Copy link
Contributor Author

crelax commented May 31, 2022

/run-integration-test

@crelax
Copy link
Contributor Author

crelax commented May 31, 2022

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2022
@crelax
Copy link
Contributor Author

crelax commented May 31, 2022

/merge

@ti-chi-bot
Copy link
Member

@crelax: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@liuzix
Copy link
Contributor

liuzix commented May 31, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4accf2e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2022
@crelax
Copy link
Contributor Author

crelax commented May 31, 2022

/run-leak-test

@crelax
Copy link
Contributor Author

crelax commented May 31, 2022

/run-kafka-integration-test

@crelax
Copy link
Contributor Author

crelax commented May 31, 2022

/run-leak-test
/run-integration-test
/run-kafka-integration-test

@crelax crelax merged commit 2e578fb into pingcap:master May 31, 2022
@crelax crelax deleted the cdc-cli-v2-tso-query branch May 31, 2022 13:13
@crelax crelax changed the title api(ticdc): add /api/v2/tso: get tso from pd api(ticdc): add /api/v2/tso: get tso from pd (Rolled Back) May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuzix liuzix liuzix approved these changes

@sdojjy sdojjy sdojjy approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiCDC Open API V2: return tso get from pd
5 participants
@crelax @ti-chi-bot @sdojjy @codecov-commenter @liuzix