Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo(ticdc): make implementation in manager asynchronously (#5683) #6199

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5683

What problem does this PR solve?

Issue Number: close #6011, ref #5920

What is changed and how it works?

  1. Make implementation in manager asynchronously.
  2. Use single goroutine bgUpdateLog to write and flush log to backend storage serially.
  3. Read redoTs directly in table_actor to decouple sinkNode's resolvedTS from redoTs.
  4. Increase the load of redo integration tests to cover large transaction scenarios.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

image

image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. area/ticdc Issues or PRs related to TiCDC. labels Jul 6, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jul 6, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-5683-to-release-6.1 branch from 34e7a0e to 3667803 Compare July 6, 2022 09:45
@CharlesCheung96
Copy link
Contributor

/run-all-tests

@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-5683-to-release-6.1 branch from 3667803 to cfb321b Compare July 6, 2022 10:33
@CharlesCheung96
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 7, 2022
@nongfushanquan
Copy link
Contributor

/run-all-tests

@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-5683-to-release-6.1 branch from cfb321b to e681df2 Compare July 7, 2022 03:08
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-6.1@be67a42). Click here to learn what that means.
The diff coverage is n/a.

Flag Coverage Δ
cdc 62.1701% <0.0000%> (?)
dm 52.0260% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.1      #6199   +/-   ##
================================================
  Coverage               ?   56.5034%           
================================================
  Files                  ?        532           
  Lines                  ?      70155           
  Branches               ?          0           
================================================
  Hits                   ?      39640           
  Misses                 ?      26744           
  Partials               ?       3771           

@CharlesCheung96
Copy link
Contributor

/run-all-tests

@CharlesCheung96
Copy link
Contributor

image

@ti-chi-bot ti-chi-bot requested a review from zhaoxinyu July 8, 2022 05:03
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9dd6c6f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2022
@hicqu
Copy link
Contributor

hicqu commented Jul 8, 2022

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit efbb1c6 into pingcap:release-6.1 Jul 8, 2022
@jayl1e jayl1e added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants