Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink, config (ticdc): enable transaction split and disable safeMode by default #7504

Merged

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Nov 1, 2022

What problem does this PR solve?

Issue Number: close #7505

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Enable transaction split and disable safeMode by default.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Nov 1, 2022
@overvenus
Copy link
Member

/run-all-tests

@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

/run-kafka-integration-tests

…men/ticdc into dongmen/default-enable-split-txn
@asddongmen
Copy link
Contributor Author

/run-kafka-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #7504 (e008507) into master (6b48846) will decrease coverage by 6.1241%.
The diff coverage is 60.7721%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.3421% <59.9201%> (-0.2958%) ⬇️
dm 52.0009% <50.0000%> (?)
engine 61.1578% <74.0000%> (-0.0259%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7504        +/-   ##
================================================
- Coverage   65.9877%   59.8635%   -6.1242%     
================================================
  Files           564        810       +246     
  Lines         52337      92811     +40474     
================================================
+ Hits          34536      55560     +21024     
- Misses        15129      32404     +17275     
- Partials       2672       4847      +2175     

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@asddongmen: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 3, 2022
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e008507

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2022
@asddongmen
Copy link
Contributor Author

/run-verify

@ti-chi-bot
Copy link
Member

@asddongmen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor Author

/run-dm-integration-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable transaction split and disable safeMode of a changefeed in TiCDC by defult.
7 participants