-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api,config(ticdc): support update transaction-atomicity and protocol via config file #7980
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
9c16b29
to
5308585
Compare
/hold wait for test result |
b0c7867
to
7c044af
Compare
7c044af
to
6c143a3
Compare
/run-verify-test |
6c143a3
to
5ee18ff
Compare
5ee18ff
to
65dc86d
Compare
/run-all-tests |
9737cbc
to
b30ad64
Compare
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b30ad64
|
/run-engine-integration-test |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
…via config file (pingcap#7980) close pingcap#7935
…via config file (pingcap#7980) close pingcap#7935
What problem does this PR solve?
Issue Number: close #7935
What is changed and how it works?
defaultMqTxnAtomicity
anddefaultMysqlTxnAtomicity
withdefaultTxnAtomicity
. Remove the logic for changing default value of TxnAtomicity) and simplify such logic inShouldSplitTxn
andvalidate
.Note compatibility change: After this pr,
transaction-atomicity
will not be automatically changed when creating changefeed and an error will be returned when any incompatible configuration is encountered.Check List
Tests
curl -X POST -H "'Content-type':'application/json'" http://127.0.0.1:8300/api/v1/changefeeds -d '{"changefeed_id":"test","sink_uri":"blackhole://root@10.1.1.1", "sink_config":{"protocol":"canal", "transaction-atomicity":"table"}}'
, then pause changefeedcurl -X PUT -H "'Content-type':'application/json'" http://127.0.0.1:8300/api/v1/changefeeds/test -d '{"sink_config":{"protocol":"canal-json", "transaction-atomicity":"none"}}'
, then query config:curl -X PUT -H "'Content-type':'application/json'" http://127.0.0.1:8300/api/v1/changefeeds/test -d '{"sink_uri":"blackhole://root@10.1.1.1?protocol=canal&transaction-atomicity=table", "sink_config":{"protocol":"avro", "transaction-atomicity":"none"}}'
curl -X PUT -H "'Content-type':'application/json'" http://127.0.0.1:8300/api/v1/changefeeds/test -d '{"sink_config":{"protocol":"avro", "transaction-atomicity":"none"}}'
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note