Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd(ticdc): print error msg if an invalid input was read (#7936) #8442

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7936

What problem does this PR solve?

Issue Number: close #7903

What is changed and how it works?

print error msg if an invalid input was read

Check List

Tests

Manual test (add detailed scripts or steps below)

  1. before
# docker run cdc:test /cdc cli changefeed create --sink-uri="blackhole://" -c storage-perf --server=10.2.6.163:8300 --start-ts=438045762164359180
Error: EOF
Replicate lag (121h36m31.6s) is larger than 1 days, large data may cause OOM, confirm to continue at your own risk [Y/N]
  1. after
# docker run cdc:test /cdc cli changefeed create --sink-uri="blackhole://" -c storage-perf --server=10.2.7.167:8301 --start-ts=438045762164359180

Replicate lag (380h54m19.605s) is larger than 1 days, large data may cause OOM, confirm to continue at your own risk [Y/N]
Received invalid input: EOF, abort the command.
Abort changefeed create.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. area/ticdc Issues or PRs related to TiCDC. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Mar 7, 2023
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-7936-to-release-6.1 branch from 8a1bf6b to 58c43f7 Compare March 7, 2023 01:53
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-7936-to-release-6.1 branch from 58c43f7 to d63ca52 Compare March 7, 2023 02:39
@CharlesCheung96
Copy link
Contributor

/run-all-tests

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.1@cc2a701). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1eebbd1 differs from pull request most recent head e89f6ac. Consider uploading reports for the commit e89f6ac to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 61.5332% <0.0000%> (?)
dm 52.0516% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.1      #8442   +/-   ##
================================================
  Coverage               ?   56.3709%           
================================================
  Files                  ?        547           
  Lines                  ?      71755           
  Branches               ?          0           
================================================
  Hits                   ?      40449           
  Misses                 ?      27457           
  Partials               ?       3849           

@CharlesCheung96
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: d63ca52

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharlesCheung96
Copy link
Contributor

/run-verify

@ti-chi-bot ti-chi-bot merged commit 4b60531 into pingcap:release-6.1 Mar 8, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants