Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink (ticdc): disable batch update dml when downstream is mysql #8452

Merged
merged 6 commits into from
Mar 7, 2023
Merged

sink (ticdc): disable batch update dml when downstream is mysql #8452

merged 6 commits into from
Mar 7, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Mar 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8420

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Fix a bug that may causes data loss when downstrem is mysql.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-triage-completed needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Mar 7, 2023
@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen asddongmen changed the title sink (ticdc): disable batch update dml for mysql sink (ticdc): disable batch update dml when downstream is mysql Mar 7, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2023
@asddongmen asddongmen mentioned this pull request Mar 7, 2023
Closed
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 7, 2023
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 781ad2a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2023
@ti-chi-bot
Copy link
Member

@asddongmen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nongfushanquan
Copy link
Contributor

/run-kafka-integration-test

1 similar comment
@nongfushanquan
Copy link
Contributor

/run-kafka-integration-test

asddongmen added a commit to asddongmen/tiflow that referenced this pull request Mar 7, 2023
@asddongmen
manually cherrypick pingcap#8452 to release-6.5
89bb5fd
@ti-chi-bot ti-chi-bot merged commit bf37f0b into pingcap:master Mar 7, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 7, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8459.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 7, 2023
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#8452
5dc9345 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 7, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8460.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 7, 2023
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#8452
9992f89 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Mar 7, 2023
@ti-chi-bot
sink (ticdc): disable batch update dml when downstream is mysql (#8452)…
7f56161 
… (#8460)

close #8420
amyangfei added a commit to amyangfei/tiflow that referenced this pull request Apr 3, 2023
@amyangfei
sink(ticdc): enable genUpdateSQLFast in TiDB conn (pingcap#8191),(pin…
4ae8d27 
…gcap#8452)
@amyangfei amyangfei mentioned this pull request Apr 3, 2023
Merged
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2023
@amyangfei
cherry pick batch update optimization (#8069) (#8191) (#8452) (#8727)
95b5db3 
ref #8084
@asddongmen asddongmen deleted the disable-batch-dml-for-mysql branch May 18, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete and update events may not be correctly sinked to downstream
5 participants
@asddongmen @ti-chi-bot @nongfushanquan @zhaoxinyu @CharlesCheung96