Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): add table default value definition for storage sink #9040

Merged
merged 4 commits into from
May 26, 2023
Merged

sink(ticdc): add table default value definition for storage sink #9040

merged 4 commits into from
May 26, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented May 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9066

What is changed and how it works?

add table default value definition for storage sink

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

need to update user documentation

Release note 

`Add table default value definition for storage sink`.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 24, 2023
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review May 24, 2023 08:23
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/check-issue-triage-complete

@CharlesCheung96
Copy link
Contributor Author

/run check-issue-triage-complete

@CharlesCheung96
Copy link
Contributor Author

/test check-issue-triage-complete

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 26, 2023

@CharlesCheung96: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tiflow/ghpr_verify

In response to this:

/test check-issue-triage-complete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharlesCheung96 CharlesCheung96 added the require-LGT1 Indicates that the PR requires an LGTM. label May 26, 2023
@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 34263ac

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 26, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 26, 2023

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit c0521a2 into pingcap:master May 26, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 26, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9070.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 26, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#9040
dec6721 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 26, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9071.

CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 26, 2023
@CharlesCheung96
sink(ticdc): add table default value definition for storage sink (pin…
8e8dabf 
…gcap#9040)

close pingcap#9066
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2023
@ti-chi-bot
sink(ticdc): add table default value definition for storage sink (#9040…
0a60f07 
…) (#9070)

close #9066
ti-chi-bot bot pushed a commit that referenced this pull request Jun 30, 2023
@ti-chi-bot
sink(ticdc): add table default value definition for storage sink (#9040…
34f6846 
…) (#9071)

close #9066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add table default value definition for storage sink
3 participants
@CharlesCheung96 @ti-chi-bot @nongfushanquan