Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read from range column partition table error (#2639) #2656

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2639

What problem does this PR solve?

close #2638

What is changed and how it works?

  1. Fix the output of explain: TiSpark no more throw NoSuchElementException when there is no partition after partition prune.

  2. Fix the part of the bug that no partitions will be selected in the range column partition table.

TiSpark will contain '' when generates partition exprs. For example, if your DDL is PARTITION p1 VALUES LESS THAN ('CN001'), you will get something like ${column_name} less than "'CN001'". Then, your filter can not match the partition exprs.

After Fix, TiSpark will convert

  • 'CN001' -> "CN001"
  • '''CN001''' -> "'CN001'"

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • shiyuhang0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member

/run-all-tests

2 similar comments
@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

@shiyuhang0: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: af17264

@ti-chi-bot ti-chi-bot merged commit e8b6a4a into pingcap:release-2.5 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants