-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize ttl #2669
optimize ttl #2669
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
1 similar comment
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7cb9b80
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
when RowIDAllocator uses 2pc to write with the TTL=3600s. Once it failed and leaves the lock, TiSpark can not resolve the lock until 3600s later for the lock is not expired.
For example, read may push the min_commit_ts, causing the RowIDAllocator 2pc to fail with
commit_ts_expired
. Then the retry can not success for lock ttl is too long.What is changed and how it works?
just set ttl to 10s
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansible
repository