Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize ttl #2669

Merged
merged 2 commits into from
Apr 17, 2023
Merged

optimize ttl #2669

merged 2 commits into from
Apr 17, 2023

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Apr 12, 2023

What problem does this PR solve?

when RowIDAllocator uses 2pc to write with the TTL=3600s. Once it failed and leaves the lock, TiSpark can not resolve the lock until 3600s later for the lock is not expired.

For example, read may push the min_commit_ts, causing the RowIDAllocator 2pc to fail with commit_ts_expired. Then the retry can not success for lock ttl is too long.

What is changed and how it works?

just set ttl to 10s

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xuanyu66
  • zhangyangyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0 shiyuhang0 added needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 needs-cherry-pick-release-3.2 and removed needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 labels Apr 12, 2023
@shiyuhang0
Copy link
Member Author

/run-all-tests

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7cb9b80

@ti-chi-bot ti-chi-bot merged commit bdb6cb4 into pingcap:master Apr 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.0: #2671.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Apr 17, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.1: #2672.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Apr 17, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.2: #2673.

ti-chi-bot added a commit that referenced this pull request Apr 18, 2023
ti-chi-bot added a commit that referenced this pull request Apr 18, 2023
ti-chi-bot added a commit that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 needs-cherry-pick-release-3.2 status/can-merge status/LGT2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants