-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TiFlash overflow (#2740) #2744
Fix TiFlash overflow (#2740) #2744
Conversation
/run-all-tests |
@shiyuhang0: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xuanyu66: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
@shiyuhang0: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shiyuhang0, xuanyu66 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #2740
What problem does this PR solve?
Reproduce:
create and insert
query from tispark with tiflash returns an error result(negative number)
What is changed and how it works?
TiSpark requests TiFlash using
TypeCHBlock
encode, but forgets to handle the UNSIGNED scenes when decoded.this pr shows how to decode it corretly
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansible
repository