Skip to content

Commit

Permalink
cluster: mark kylin v10 as supported OS (#2079)
Browse files Browse the repository at this point in the history
  • Loading branch information
kaaaaaaang authored Nov 21, 2022
1 parent fecb02e commit 1fd18a0
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions pkg/cluster/operation/check.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,10 @@ func checkOSInfo(opt *CheckOptions, osInfo *sysinfo.OS) *CheckResult {
// check OS vendor
switch osInfo.Vendor {
case "kylin":
msg := "kylin support is not fully tested, be careful"
result.Err = fmt.Errorf("%s (%s)", result.Msg, msg)
result.Warn = true
// VERSION_ID="V10"
if ver, _ := strconv.ParseFloat(strings.Trim(osInfo.Version, "V"), 64); ver < 10 {
result.Err = fmt.Errorf("%s %s not supported, use version V10 or higher(%s)",
osInfo.Name, osInfo.Release, msg)
result.Err = fmt.Errorf("%s %s not supported, use version V10 or higher",
osInfo.Name, osInfo.Release)
return result
}
case "amzn":
Expand All @@ -187,8 +184,6 @@ func checkOSInfo(opt *CheckOptions, osInfo *sysinfo.OS) *CheckResult {
}
case "centos", "redhat", "rhel", "ol":
// check version
// CentOS 8 is known to be not working, and we don't have plan to support it
// as of now, we may add support for RHEL 8 based systems in the future.
if ver, _ := strconv.ParseFloat(osInfo.Version, 64); ver < 7 {
result.Err = fmt.Errorf("%s %s not supported, use version 8 please",
osInfo.Name, osInfo.Release)
Expand Down

0 comments on commit 1fd18a0

Please sign in to comment.