cluster: exclude spark from start/stop actions

pkg/cluster/operation/action.go

@@ -389,6 +389,19 @@ func RestartComponent(getter ExecutorGetter, instances []spec.Instance, timeout
 	log.Infof("Restarting component %s", name)
 
 	for _, ins := range instances {
+		// tispark need to be started manually by user
+		switch ins.Role() {
+		case spec.RoleTiSparkMaster:
+			log.Warnf(
+				"TiSpark need to be restarted manually, please login to the server and execute stop-master.sh and start-master.sh in %s",
+				ins.DeployDir(), ins.DeployDir())
+			continue
+		case spec.RoleTiSparkSlave:
+			log.Warnf(
+				"TiSpark need to be restarted manually, please login to the server and execute stop-slave.sh and start-slave.sh in %s",
+				ins.DeployDir(), ins.DeployDir())
+			continue
+		}
 		e := getter.Get(ins.GetHost())
 		log.Infof("\tRestarting instance %s", ins.GetHost())
 
@@ -427,6 +440,20 @@ func RestartComponent(getter ExecutorGetter, instances []spec.Instance, timeout
 }
 
 func startInstance(getter ExecutorGetter, ins spec.Instance, timeout int64) error {
+	// tispark need to be started manually by user
+	switch ins.Role() {
+	case spec.RoleTiSparkMaster:
+		log.Warnf(
+			"TiSpark need to be started manually, please login to the server and execute %s/start-master.sh",
+			ins.DeployDir(), ins.DeployDir())
+		return nil
+	case spec.RoleTiSparkSlave:
+		log.Warnf(
+			"TiSpark need to be started manually, please login to the server and execute %s/start-slave.sh",
+			ins.DeployDir(), ins.DeployDir())
+		return nil
+	}
+
 	e := getter.Get(ins.GetHost())
 	log.Infof("\tStarting instance %s %s:%d",
 		ins.ComponentName(),
@@ -561,6 +588,20 @@ func StopMonitored(getter ExecutorGetter, instance spec.Instance, options spec.M
 }
 
 func stopInstance(getter ExecutorGetter, ins spec.Instance) error {
+	// tispark need to be stopped manually by user
+	switch ins.Role() {
+	case spec.RoleTiSparkMaster:
+		log.Warnf(
+			"TiSpark need to be stopped manually, please login to the server and execute %s/stop-master.sh",
+			ins.DeployDir(), ins.DeployDir())
+		return nil
+	case spec.RoleTiSparkSlave:
+		log.Warnf(
+			"TiSpark need to be stopped manually, please login to the server and execute %s/stop-slave.sh",
+			ins.DeployDir(), ins.DeployDir())
+		return nil
+	}
+
 	e := getter.Get(ins.GetHost())
 	log.Infof("\tStopping instance %s", ins.GetHost())
 

pkg/cluster/spec/spec.go

@@ -36,7 +36,9 @@ const (
 
 // general role names
 var (
-	RoleMonitor = "monitor"
+	RoleMonitor       = "monitor"
+	RoleTiSparkMaster = "tispark-master"
+	RoleTiSparkSlave  = "tispark-slave"
 )
 
 type (

pkg/cluster/spec/tispark.go

@@ -41,7 +41,7 @@ type TiSparkMasterSpec struct {
 
 // Role returns the component role of the instance
 func (s TiSparkMasterSpec) Role() string {
-	return ComponentTiSpark
+	return RoleTiSparkMaster
 }
 
 // SSH returns the host and SSH port of the instance
@@ -75,7 +75,7 @@ type TiSparkSlaveSpec struct {
 
 // Role returns the component role of the instance
 func (s TiSparkSlaveSpec) Role() string {
-	return ComponentTiSpark
+	return RoleTiSparkSlave
 }
 
 // SSH returns the host and SSH port of the instance
@@ -122,7 +122,7 @@ func (c *TiSparkMasterComponent) Instances() []Instance {
 					s.DeployDir,
 				},
 				statusFn: func(_ ...string) string {
-					return "-"
+					return "N/A"
 				},
 			},
 		})
@@ -243,7 +243,7 @@ func (c *TiSparkSlaveComponent) Instances() []Instance {
 					s.DeployDir,
 				},
 				statusFn: func(_ ...string) string {
-					return "-"
+					return "N/A"
 				},
 			},
 		})