Fix the issue that it may panic when user try to list expired compone…

…nt (#1391)
pingcap · May 28, 2021 · 5928416 · 5928416
1 parent d1734e3
commit 5928416
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/repository/v1_repository.go b/pkg/repository/v1_repository.go
@@ -450,7 +450,11 @@ func (r *V1Repository) updateComponentManifest(id string, withYanked bool) (*v1m
 
 	if oldVersion != 0 && oldVersion == fileVersion.Version {
 		// We're up to date, load the old manifest from disk.
-		return r.local.LoadComponentManifest(&item, filename)
+		comp, err := r.local.LoadComponentManifest(&item, filename)
+		if comp == nil && err == nil {
+			err = fmt.Errorf("component %s does not exist", id)
+		}
+		return comp, err
 	}
 
 	var component v1manifest.Component