cluster: ignore error when increasing schedule limit during upgrade

pingcap · May 12, 2021 · c330e77 · c330e77
1 parent b1b03c9
commit c330e77
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/cluster/operation/upgrade.go b/pkg/cluster/operation/upgrade.go
@@ -64,7 +64,10 @@ func Upgrade(
 			pdClient := api.NewPDClient(topo.(*spec.Specification).GetPDList(), 10*time.Second, tlsCfg)
 			origLeaderScheduleLimit, origRegionScheduleLimit, err = increaseScheduleLimit(ctx, pdClient)
 			if err != nil {
-				return err
+				// the config modifing error should be able to be safely ignored, as it will
+				// be processed with current settings anyway.
+				log.Warnf("failed increasing schedule limit: %s, ignore", err)
+				continue
 			}
 			defer func() {
 				upgErr := decreaseScheduleLimit(pdClient, origLeaderScheduleLimit, origRegionScheduleLimit)