Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inheriting enable_binlog setting when importing TiDB Ansible cluster to TiUP #714

Closed
Arthas18 opened this issue Aug 25, 2020 · 1 comment
Closed

Support inheriting enable_binlog setting when importing TiDB Ansible cluster to TiUP #714

Arthas18 opened this issue Aug 25, 2020 · 1 comment
Labels
type/feature-request Categorizes issue as related to a new feature.

Comments

@Arthas18
Copy link

Feature Request

Is your feature request related to a problem? Please describe:
TiDB Binlog is enabled by setting enable_binlog to true in TiDB Ansible inventory, but the setting is lost when TiDB cluster is imported to TiUP. It may lead to binlog service closed unexpectedly and synchronization interruption after
subsequent operations such as version upgrade.

Describe the feature you'd like:
When import inventory.ini configuration to TiUP, check enable_binlog setting and inherit it in TiUP topology file.

Describe alternatives you've considered:
Add additional instructions in documents.

Teachability, Documentation, Adoption, Migration Strategy:
@Arthas18 Arthas18 added the type/feature-request Categorizes issue as related to a new feature. label Aug 25, 2020
@july2993
Copy link
Contributor

should be fixed by #652 but not released yes cc @AstroProfundis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@july2993 @Arthas18