-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster/import: read enable_binlog from inventory #652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 56.71% 57.34% +0.63%
==========================================
Files 242 243 +1
Lines 17469 17512 +43
==========================================
+ Hits 9908 10043 +135
+ Misses 6265 6167 -98
- Partials 1296 1302 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
The
enable_binlog
switch in ansible inventory is not imported.What is changed and how it works?
Read the variable and set tidb config if it is set to True.
Release Note