Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster-version and ansible dir params in 'tiup dm import' are mandatory, please add them in command help info #792

Closed
seiya-annie opened this issue Sep 17, 2020 · 0 comments · Fixed by #1089
Closed

cluster-version and ansible dir params in 'tiup dm import' are mandatory, please add them in command help info #792

seiya-annie opened this issue Sep 17, 2020 · 0 comments · Fixed by #1089
Labels
ansible Categorizes issue as related to tidb-ansible status/TODO Categorizes issue as we will do it. type/bug Categorizes issue as related to a bug.
Milestone
v1.3.2

Comments

@seiya-annie
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    [root@localhost ~]# tiup dm import --help
    Import an exist DM 1.0 cluster from dm-ansible and re-deploy 2.0 version

Usage:
tiup dm import [flags]

  1. What did you expect to see?
    -v, --cluster-version string cluster version of DM to deploy
    -d, --dir string The path to DM-Ansible directory (default "./")
    these two params are mandatory to the command, but they are described as optional now

  2. What did you see instead?
    Usage:
    tiup dm import [flags]

  3. What version of TiUP are you using (tiup --version)?
    [root@localhost ~]# tiup --version
    v1.0.9 tiup
    Go Version: go1.13
    Git Branch: master
    GitHash: 41fbacf
    [root@localhost ~]# tiup dm --version
    Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm --version
    tiup version v1.1.2 tiup
    Go Version: go1.13
    Git Branch: release-1.1
    GitHash: 7cb85b9-dirty
@seiya-annie seiya-annie added the type/bug Categorizes issue as related to a bug. label Sep 17, 2020
@lucklove lucklove added the status/TODO Categorizes issue as we will do it. label Sep 17, 2020
@lucklove lucklove added this to the v1.3.1 milestone Oct 19, 2020
@lucklove lucklove added the ansible Categorizes issue as related to tidb-ansible label Dec 10, 2020
@lucklove lucklove modified the milestones: v1.3.1, v1.3.2 Dec 29, 2020
lucklove added a commit to lucklove/tiup that referenced this issue Jan 22, 2021
@lucklove
Mark required flag in help message
3cc65cf 
Fix pingcap#792
@lucklove lucklove mentioned this issue Jan 22, 2021
Merged
ti-chi-bot added a commit that referenced this issue Jan 25, 2021
@lucklove @ti-chi-bot
Mark required flag in help message (#1089)
fe8a3b8 
Fix #792

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
lucklove added a commit that referenced this issue Jan 28, 2021
@lucklove @ti-chi-bot
Mark required flag in help message (#1089)
0069669 
Fix #792

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
mianhk pushed a commit to mianhk/tiup that referenced this issue Jan 29, 2021
@lucklove @ti-chi-bot @mianhk
Mark required flag in help message (pingcap#1089)
8c8d922 
Fix pingcap#792

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ansible Categorizes issue as related to tidb-ansible status/TODO Categorizes issue as we will do it. type/bug Categorizes issue as related to a bug.
Projects
None yet
Milestone
v1.3.2
Development

Successfully merging a pull request may close this issue.

Mark required flag in help message lucklove/tiup
2 participants
@lucklove @seiya-annie