Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiup mirror merge usage #1008

Merged
merged 2 commits into from
Dec 24, 2020
Merged

Conversation

lucklove
Copy link
Member

No description provided.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 24, 2020
@codecov-io
Copy link

codecov-io commented Dec 24, 2020

Codecov Report

Merging #1008 (ea320c8) into master (081877a) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
- Coverage   55.66%   55.26%   -0.41%     
==========================================
  Files         279      279              
  Lines       19743    19743              
==========================================
- Hits        10990    10911      -79     
- Misses       7042     7128      +86     
+ Partials     1711     1704       -7     
Flag Coverage Δ
cluster 43.02% <ø> (-0.57%) ⬇️
dm 23.95% <ø> (-0.02%) ⬇️
integrate 49.49% <100.00%> (-0.45%) ⬇️
playground 20.32% <ø> (ø)
tiup 16.48% <100.00%> (ø)
unittest 23.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/mirror.go 48.63% <100.00%> (ø)
pkg/cluster/api/pdapi.go 53.25% <0.00%> (-7.44%) ⬇️
pkg/cluster/operation/scale_in.go 50.99% <0.00%> (-7.29%) ⬇️
pkg/cliutil/cliutil.go 60.71% <0.00%> (-7.15%) ⬇️
pkg/cluster/manager/destroy.go 64.78% <0.00%> (-5.64%) ⬇️
pkg/utils/http_client.go 67.56% <0.00%> (-5.41%) ⬇️
pkg/cluster/manager/display.go 79.52% <0.00%> (-3.15%) ⬇️
pkg/cluster/task/update_meta.go 76.92% <0.00%> (-3.08%) ⬇️
pkg/cluster/spec/tiflash.go 69.94% <0.00%> (-2.90%) ⬇️
pkg/cluster/spec/tispark.go 64.86% <0.00%> (-2.71%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081877a...ea320c8. Read the comment docs.

@AstroProfundis
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 24, 2020
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ea320c8

@ti-chi-bot ti-chi-bot merged commit d7fed64 into pingcap:master Dec 24, 2020
@lucklove lucklove added this to the v1.3.1 milestone Dec 31, 2020
lucklove added a commit that referenced this pull request Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants