Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warn on clean log #1029

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Add warn on clean log #1029

merged 1 commit into from
Dec 30, 2020

Conversation

lucklove
Copy link
Member

Fix #1028

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2020
@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #1029 (43bc762) into master (3701f8a) will decrease coverage by 25.82%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1029       +/-   ##
===========================================
- Coverage   55.68%   29.85%   -25.83%     
===========================================
  Files         280      266       -14     
  Lines       19749    18410     -1339     
===========================================
- Hits        10997     5497     -5500     
- Misses       7044    12065     +5021     
+ Partials     1708      848      -860     
Flag Coverage Δ
cluster ?
dm ?
integrate 21.55% <ø> (-28.41%) ⬇️
playground 20.31% <ø> (ø)
tiup 16.48% <ø> (ø)
unittest 22.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/cleanup.go 0.00% <0.00%> (-49.19%) ⬇️
pkg/meta/paths.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/utils.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/logger/log/log.go 0.00% <0.00%> (-100.00%) ⬇️
components/cluster/main.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/bindversion.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/task/builder.go 0.00% <0.00%> (-97.11%) ⬇️
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3701f8a...43bc762. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2020
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 43bc762

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2020
@AstroProfundis AstroProfundis added this to the v1.3.1 milestone Dec 30, 2020
@ti-chi-bot ti-chi-bot merged commit 3b0c5c6 into pingcap:master Dec 30, 2020
lucklove added a commit that referenced this pull request Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup-clean --log add warining
4 participants