Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update go mod dependencies #1046

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Update bunch of dependencies, especially update PD to v5.0.0-rc.

Check List

Tests

  • Unit test
  • Integration test

Release notes:

NONE

@AstroProfundis AstroProfundis added the type/enhancement Categorizes issue or PR as related to an enhancement. label Jan 7, 2021
@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Jan 7, 2021
@AstroProfundis AstroProfundis self-assigned this Jan 7, 2021
@ti-chi-bot ti-chi-bot requested review from lonng and lucklove January 7, 2021 12:05
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2021
@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #1046 (f15a568) into master (8feef43) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage   55.77%   55.70%   -0.08%     
==========================================
  Files         280      280              
  Lines       19759    19759              
==========================================
- Hits        11021    11007      -14     
- Misses       7033     7041       +8     
- Partials     1705     1711       +6     
Flag Coverage Δ
cluster 43.66% <ø> (-0.08%) ⬇️
dm 24.05% <ø> (-0.07%) ⬇️
integrate 49.99% <100.00%> (-0.08%) ⬇️
playground 20.31% <100.00%> (ø)
tiup 16.48% <ø> (ø)
unittest 22.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tui/tui.go 80.00% <ø> (ø)
components/playground/playground.go 41.63% <100.00%> (ø)
pkg/utils/http_client.go 67.56% <0.00%> (-5.41%) ⬇️
pkg/cluster/template/scripts/pd.go 68.75% <0.00%> (-3.13%) ⬇️
pkg/cluster/api/pdapi.go 58.67% <0.00%> (-1.90%) ⬇️
pkg/cluster/api/dmapi.go 58.26% <0.00%> (-1.74%) ⬇️
pkg/cluster/spec/pd.go 67.51% <0.00%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8feef43...f15a568. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented Jan 7, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2021
@lucklove
Copy link
Member

lucklove commented Jan 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f15a568

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 7, 2021
@ti-chi-bot ti-chi-bot merged commit b5fe5e8 into pingcap:master Jan 7, 2021
@AstroProfundis AstroProfundis deleted the update-mods branch January 8, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants