-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: allow type change when editing topology #1050
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
+ Coverage 55.86% 55.95% +0.09%
==========================================
Files 282 282
Lines 19868 19869 +1
==========================================
+ Hits 11099 11118 +19
+ Misses 7040 7029 -11
+ Partials 1729 1722 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: dec4375
|
@AstroProfundis: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository. |
What problem does this PR solve?
Allowing value type change for
edit-config
. Especially useful when editing configs.What is changed and how it works?
The latest version of
r3labs/diff
has an option to ignore type mismatch error, so we upgrade the dependency and enable that option.Check List
Tests
(Change
tikv_servers.(server).config.key: 10
totikv_servers.(server).config.key: "10MB"
)Before:
After:
Save as normal.
Release notes: