-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue that the expires shortened after merging cloned mirror #1051
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
- Coverage 55.98% 55.89% -0.09%
==========================================
Files 282 282
Lines 19892 19896 +4
==========================================
- Hits 11136 11121 -15
- Misses 7032 7044 +12
- Partials 1724 1731 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c1cbe13
|
@lucklove: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository. |
…1051) Co-authored-by: Ti Prow Robot <71242396+ti-community-prow-bot@users.noreply.github.com>
What problem does this PR solve?
For the cloned mirror, we set the expires filed expire after 50 years since the user rarely modify the mirror so we can assume that's safe. However, when the user try to publish component to the cloned mirror, the problem occurred:the expire time will be shortened to just one. month because we think it's unsafe if the user need to modify it. It's OK when the user need to modify it frequently, because every time he modify it, the expire time will be push forward to a month latter. However, what if the user just modify it once and use it alone the time? The mirror will expire after a month so that the user must modify it again in a month even though he don't want to do that.
What is changed and how it works?
We compare the new expire time and the old one, use the longer one.
Check List
Tests
Code changes
Side effects
Related changes
Release notes: