Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that dm grafana doen't has home.json #1056

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

lucklove
Copy link
Member

Introduced by #982

Close #1055

@ti-chi-bot ti-chi-bot requested a review from nrc January 11, 2021 08:57
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2021
@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #1056 (c4b9899) into master (b9c6bae) will decrease coverage by 3.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
- Coverage   55.49%   51.74%   -3.75%     
==========================================
  Files         282      282              
  Lines       19868    19868              
==========================================
- Hits        11025    10280     -745     
- Misses       7121     7960     +839     
+ Partials     1722     1628      -94     
Flag Coverage Δ
cluster 38.30% <50.00%> (-5.10%) ⬇️
dm 23.94% <100.00%> (ø)
integrate 45.98% <100.00%> (-3.76%) ⬇️
playground 20.31% <ø> (ø)
tiup 16.48% <0.00%> (ø)
unittest 22.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/grafana.go 68.00% <100.00%> (ø)
components/cluster/command/check.go 6.73% <0.00%> (-72.76%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/cluster/task/copy_file.go 0.00% <0.00%> (-54.55%) ⬇️
components/cluster/command/audit.go 27.27% <0.00%> (-54.55%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-53.07%) ⬇️
pkg/cluster/manager/patch.go 0.00% <0.00%> (-51.81%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/cluster/manager/cleanup.go 0.00% <0.00%> (-49.19%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c6bae...c4b9899. Read the comment docs.

@9547
Copy link
Contributor

9547 commented Jan 11, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 714f33c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2021
@ti-chi-bot
Copy link
Member

@lucklove: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot ti-chi-bot merged commit a246cfa into pingcap:master Jan 12, 2021
lucklove added a commit that referenced this pull request Jan 28, 2021
Introduced by #982

Close #1055

Co-authored-by: Ti Prow Robot <71242396+ti-community-prow-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiUP DM 2.0.1 component grafana appear error: Failed to fetch dashboard
5 participants