Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: improve check subcommand #1099

Merged
merged 3 commits into from
Jan 28, 2021
Merged

cluster: improve check subcommand #1099

merged 3 commits into from
Jan 28, 2021

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Jan 26, 2021 •
edited
Loading

What problem does this PR solve?

Close #912
Close #1021

What is changed and how it works?

Add checks to the check subcommand

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    图片
    图片

Side effects

  • Increased code complexity

Release notes:

cluster: improve checking rules in `check` subcommand

@AstroProfundis AstroProfundis added type/new-feature Categorizes pr as related to a new feature. type/enhancement Categorizes issue or PR as related to an enhancement. category/usability Categorizes issue or PR as a usability enhancement. category/stability Categorizes issue or PR as a stability enhancement. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 26, 2021
@AstroProfundis AstroProfundis self-assigned this Jan 26, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2021
@ti-chi-bot ti-chi-bot requested a review from july2993 January 26, 2021 08:34
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 26, 2021
@AstroProfundis AstroProfundis removed the request for review from july2993 January 26, 2021 08:34
@pingcap pingcap deleted a comment from ti-srebot Jan 26, 2021
@AstroProfundis AstroProfundis added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2021
@codecov-io
Copy link

codecov-io commented Jan 26, 2021 •
edited
Loading

Codecov Report

Merging #1099 (0cce5fc) into master (080f833) will decrease coverage by 7.54%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
- Coverage   56.67%   49.12%   -7.55%     
==========================================
  Files         283      283              
  Lines       20047    20106      +59     
==========================================
- Hits        11361     9878    -1483     
- Misses       6934     8683    +1749     
+ Partials     1752     1545     -207
Flag Coverage Δ
cluster 32.59% <0.00%> (-12.56%) ⬇️
dm 24.76% <0.00%> (-0.10%) ⬇️
integrate 42.58% <0.00%> (-8.48%) ⬇️
playground 20.89% <ø> (ø)
tiup 16.34% <ø> (ø)
unittest 22.80% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/check.go 0.00% <0.00%> (-53.20%) ⬇️
pkg/cluster/task/check.go 0.00% <0.00%> (-25.97%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/queue/any_queue.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/cluster/template/scripts/tiflash.go 0.00% <0.00%> (-79.60%) ⬇️
components/cluster/command/check.go 6.56% <0.00%> (-73.13%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/template/systemd/tispark.go 0.00% <0.00%> (-68.00%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080f833...0cce5fc. Read the comment docs.

@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 28, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4f19e80

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 28, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 2e2e439 into pingcap:master Jan 28, 2021
@AstroProfundis AstroProfundis deleted the improve-check branch January 28, 2021 09:03
@lucklove lucklove added the status/need-doc Indicates that we should update document before merge a PR. label Jan 29, 2021
mianhk pushed a commit to mianhk/tiup that referenced this pull request Jan 29, 2021
@AstroProfundis @ti-chi-bot @mianhk
cluster: improve check subcommand (pingcap#1099)
e1ecb7d 
* cluster/check: check for multiple instances using the same partition as data_dir

* cluster/check: check for JRE for TiSpark nodes

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove Awaiting requested review from lucklove

Assignees

@AstroProfundis AstroProfundis

Labels
category/stability Categorizes issue or PR as a stability enhancement. category/usability Categorizes issue or PR as a usability enhancement. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/need-doc Indicates that we should update document before merge a PR. type/enhancement Categorizes issue or PR as related to an enhancement. type/new-feature Categorizes pr as related to a new feature.
Projects
None yet
Milestone
No milestone
4 participants
@AstroProfundis @codecov-io @lucklove @ti-chi-bot