Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cliutil: return user's answer on prompt #1104

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Close #1090

Release notes:

tui: add user's answer in the error message if prompted challenge didn't pass

@AstroProfundis AstroProfundis added type/enhancement Categorizes issue or PR as related to an enhancement. category/usability Categorizes issue or PR as a usability enhancement. labels Jan 27, 2021
@AstroProfundis AstroProfundis self-assigned this Jan 27, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 08989a8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2021
@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #1104 (08989a8) into master (4558d4b) will decrease coverage by 32.23%.
The diff coverage is 12.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1104       +/-   ##
===========================================
- Coverage   56.67%   24.44%   -32.24%     
===========================================
  Files         283      221       -62     
  Lines       20047    16092     -3955     
===========================================
- Hits        11361     3933     -7428     
- Misses       6934    11424     +4490     
+ Partials     1752      735     -1017     
Flag Coverage Δ
cluster ?
dm 24.44% <12.50%> (-0.42%) ⬇️
integrate 24.44% <12.50%> (-26.63%) ⬇️
playground ?
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/edit_config.go 31.25% <0.00%> (ø)
pkg/cliutil/tui.go 59.18% <16.66%> (ø)
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/telemetry/scrub.go 0.00% <0.00%> (-86.67%) ⬇️
pkg/queue/any_queue.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/cluster/spec/bindversion.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/cluster/spec/cdc.go 0.00% <0.00%> (-82.76%) ⬇️
... and 200 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4558d4b...08989a8. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 080f833 into pingcap:master Jan 27, 2021
mianhk pushed a commit to mianhk/tiup that referenced this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more accurate error notification
4 participants