Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cluster/operation): extract the correct java's version field #1124

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Feb 2, 2021

What problem does this PR solve?

The old jdk8's version as below:

# java -version
openjdk version "1.8.0_265"
OpenJDK Runtime Environment (build 1.8.0_265-b01)
OpenJDK 64-Bit Server VM (build 25.265-b01, mixed mode)

But the newly Java(11 or higher)'s version as below:

# java -version
openjdk version "11.0.8" 2020-07-14
OpenJDK Runtime Environment (build 11.0.8+10-post-Debian-1deb10u1)
OpenJDK 64-Bit Server VM (build 11.0.8+10-post-Debian-1deb10u1, mixed mode, sharing)

And as TiSpark 用户指南 | PingCAP Docs saied, TiSpark needs JDK 1.8+

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-srebot
Copy link
Contributor

This issue contains Chinese, please use English.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 2, 2021
@ti-chi-bot ti-chi-bot requested a review from july2993 February 2, 2021 15:56
@9547
Copy link
Contributor Author

9547 commented Feb 2, 2021

/cc @AstroProfundis

@AstroProfundis
Copy link
Contributor

AstroProfundis commented Feb 3, 2021

I remember I've tested that only Jave 1.8 is working as the Spark we bundled is quite old. @marsishandsome could you confirm the JRE version requirement?

@AstroProfundis AstroProfundis added the status/need-info More information or actions need to be fufilled before we can process. label Feb 20, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cbc0867

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-chi-bot
Copy link
Member

@9547: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c3f11c5 into pingcap:master Feb 22, 2021
@9547 9547 deleted the fix/check-java-version branch April 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/need-info More information or actions need to be fufilled before we can process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants