-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove io/ioutil as changed in Go 1.16 #1153
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
===========================================
- Coverage 53.52% 38.84% -14.68%
===========================================
Files 284 256 -28
Lines 20299 18898 -1401
===========================================
- Hits 10865 7341 -3524
- Misses 7756 10241 +2485
+ Partials 1678 1316 -362
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 63c6fd7
|
@AstroProfundis: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
The package
io/ioutil
is deprecated in Go 1.16 and been replaced by newos
andio
packages.What is changed and how it works?
Since we bumped minimal required Go version to
1.16
in #1151, it's now safe to remove usage ofio/ioutil
from the code base.Check List
Tests
Code changes
Side effects
Release notes: