Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove io/ioutil as changed in Go 1.16 #1153

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Feb 24, 2021

What problem does this PR solve?

The package io/ioutil is deprecated in Go 1.16 and been replaced by new os and io packages.

What is changed and how it works?

Since we bumped minimal required Go version to 1.16 in #1151, it's now safe to remove usage of io/ioutil from the code base.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • Breaking backward compatibility

Release notes:

*: replace `io/ioutil` with `io` and `os` packages

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 24, 2021
@AstroProfundis AstroProfundis requested review from lucklove and removed request for lonng and breezewish February 24, 2021 04:46
@AstroProfundis AstroProfundis added the type/enhancement Categorizes issue or PR as related to an enhancement. label Feb 24, 2021
@codecov-io
Copy link

codecov-io commented Feb 24, 2021

Codecov Report

Merging #1153 (83b117f) into master (e92af4f) will decrease coverage by 14.67%.
The diff coverage is 59.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1153       +/-   ##
===========================================
- Coverage   53.52%   38.84%   -14.68%     
===========================================
  Files         284      256       -28     
  Lines       20299    18898     -1401     
===========================================
- Hits        10865     7341     -3524     
- Misses       7756    10241     +2485     
+ Partials     1678     1316      -362     
Flag Coverage Δ
cluster 36.40% <55.00%> (-8.63%) ⬇️
dm ?
integrate 38.84% <59.79%> (-9.05%) ⬇️
playground 2.93% <9.37%> (-0.01%) ⬇️
tiup 16.36% <17.80%> (+<0.01%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/clean.go 32.35% <0.00%> (ø)
cmd/mirror.go 48.51% <0.00%> (ø)
cmd/status.go 27.02% <0.00%> (ø)
components/playground/monitor.go 0.00% <0.00%> (ø)
components/playground/playground.go 0.00% <0.00%> (ø)
pkg/cluster/ansible/config.go 0.00% <ø> (ø)
pkg/cluster/ansible/inventory.go 0.00% <0.00%> (-54.75%) ⬇️
pkg/cluster/manager/edit_config.go 0.00% <0.00%> (-31.25%) ⬇️
pkg/cluster/spec/drainer.go 58.76% <0.00%> (ø)
pkg/cluster/spec/pd.go 56.02% <0.00%> (-12.05%) ⬇️
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92af4f...83b117f. Read the comment docs.

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 63c6fd7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9ac1cf1 into pingcap:master Feb 24, 2021
@AstroProfundis AstroProfundis deleted the rm-ioutil branch February 24, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants