-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue that can't gernerate prometheus config #1185
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f0fe317
|
Merge canceled because a new commit is pushed. |
Codecov Report
@@ Coverage Diff @@
## release-1.3 #1185 +/- ##
================================================
+ Coverage 16.72% 45.28% +28.55%
================================================
Files 144 265 +121
Lines 11082 19090 +8008
================================================
+ Hits 1854 8644 +6790
- Misses 8746 9129 +383
- Partials 482 1317 +835
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
Fix #1184, Fix #1186
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: