Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that prune command will regen config for removed nodes #1237

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Mar 23, 2021

What problem does this PR solve?

Fix #1236

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from breezewish March 23, 2021 03:45
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 23, 2021
@codecov-io
Copy link

codecov-io commented Mar 23, 2021

Codecov Report

Merging #1237 (ad7cfc1) into master (4d5347d) will decrease coverage by 12.36%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1237       +/-   ##
===========================================
- Coverage   53.42%   41.06%   -12.37%     
===========================================
  Files         289      287        -2     
  Lines       20625    20558       -67     
===========================================
- Hits        11019     8442     -2577     
- Misses       7885    10833     +2948     
+ Partials     1721     1283      -438     
Flag Coverage Δ
cluster 30.79% <57.14%> (-14.21%) ⬇️
dm 24.57% <0.00%> (-0.45%) ⬇️
integrate 33.61% <57.14%> (-14.26%) ⬇️
playground 3.09% <ø> (+<0.01%) ⬆️
tiup ?
unittest 22.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/destroy.go 53.84% <44.44%> (-14.65%) ⬇️
main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/cluster/template/scripts/tiflash.go 0.00% <0.00%> (-79.60%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-71.43%) ⬇️
pkg/cluster/manager/check.go 0.00% <0.00%> (-69.39%) ⬇️
cmd/env.go 23.07% <0.00%> (-69.24%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5347d...ad7cfc1. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ad7cfc1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2021
@AstroProfundis AstroProfundis added the type/bug-fix Categorizes PR as a bug-fix label Mar 24, 2021
@ti-chi-bot ti-chi-bot merged commit 3fbcafb into pingcap:master Mar 24, 2021
@lucklove lucklove added this to the v1.3.7 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster prune (tombstone tikv)ERROR
4 participants