Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: Type -> Rule in confirmTopology #1252

Merged
merged 6 commits into from
Mar 31, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Mar 27, 2021

What problem does this PR solve?

IN tiup cluster display the topology's header is like below:

image

But in tiup cluster scale-out the topology's header is like below:

image

Let's be consistent

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from lonng March 27, 2021 06:17
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2021
@codecov-io
Copy link

codecov-io commented Mar 27, 2021

Codecov Report

Merging #1252 (2610433) into master (b56c8ad) will increase coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   26.17%   26.59%   +0.42%     
==========================================
  Files         263      224      -39     
  Lines       18841    17027    -1814     
==========================================
- Hits         4931     4529     -402     
+ Misses      13144    11647    -1497     
- Partials      766      851      +85     
Flag Coverage Δ
dm 26.59% <100.00%> (?)
integrate 26.59% <100.00%> (+10.06%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/manager.go 63.46% <100.00%> (+63.46%) ⬆️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/telemetry/scrub.go 0.00% <0.00%> (-86.67%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-76.48%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/spec/validate.go 19.44% <0.00%> (-71.71%) ⬇️
... and 221 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56c8ad...2610433. Read the comment docs.

@9547 9547 force-pushed the fix/scale-out-header branch from 963f2be to cca34f4 Compare March 29, 2021 16:47
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cca34f4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2021
@AstroProfundis AstroProfundis merged commit 00dcee8 into pingcap:master Mar 31, 2021
@lucklove lucklove added this to the v1.4.1 milestone Apr 1, 2021
@AstroProfundis AstroProfundis modified the milestones: v1.4.1, v1.4.0 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants