-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: Type -> Rule in confirmTopology #1252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
+ Coverage 26.17% 26.59% +0.42%
==========================================
Files 263 224 -39
Lines 18841 17027 -1814
==========================================
- Hits 4931 4529 -402
+ Misses 13144 11647 -1497
- Partials 766 851 +85
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
963f2be
to
cca34f4
Compare
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cca34f4
|
What problem does this PR solve?
IN
tiup cluster display
the topology's header is like below:But in
tiup cluster scale-out
the topology's header is like below:Let's be consistent
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: