Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix releasing workflow #1257

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix releasing CI, the upload to release assets step was failing.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Mar 30, 2021
@AstroProfundis AstroProfundis self-assigned this Mar 30, 2021
@ti-chi-bot ti-chi-bot requested review from lonng and lucklove March 30, 2021 11:40
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 30, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 30, 2021
@codecov-io
Copy link

codecov-io commented Mar 30, 2021

Codecov Report

Merging #1257 (8928fa5) into master (b56c8ad) will increase coverage by 13.89%.
The diff coverage is n/a.

❗ Current head 8928fa5 differs from pull request most recent head 4fba4e5. Consider uploading reports for the commit 4fba4e5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1257       +/-   ##
===========================================
+ Coverage   26.17%   40.06%   +13.89%     
===========================================
  Files         263      286       +23     
  Lines       18841    20676     +1835     
===========================================
+ Hits         4931     8284     +3353     
+ Misses      13144    11148     -1996     
- Partials      766     1244      +478     
Flag Coverage Δ
cluster 35.67% <ø> (?)
integrate 33.37% <ø> (+16.83%) ⬆️
playground 3.09% <ø> (?)
tiup ?
unittest 22.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-71.43%) ⬇️
cmd/env.go 23.07% <0.00%> (-69.24%) ⬇️
pkg/exec/run.go 0.00% <0.00%> (-55.63%) ⬇️
pkg/utils/args.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/repository/model/model.go 0.00% <0.00%> (-46.62%) ⬇️
pkg/repository/v1manifest/repo.go 0.00% <0.00%> (-44.80%) ⬇️
pkg/environment/env.go 13.33% <0.00%> (-44.17%) ⬇️
cmd/uninstall.go 31.66% <0.00%> (-41.67%) ⬇️
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00dcee8...4fba4e5. Read the comment docs.

@AstroProfundis AstroProfundis force-pushed the fix-release branch 2 times, most recently from 62a1ab2 to 164caed Compare March 31, 2021 07:01
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f670921

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit bb57564 into pingcap:master Mar 31, 2021
@AstroProfundis AstroProfundis deleted the fix-release branch March 31, 2021 08:41
AstroProfundis added a commit that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants