-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the dir check logic on imported cluster #1273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
===========================================
+ Coverage 26.17% 50.09% +23.91%
===========================================
Files 263 289 +26
Lines 18915 20875 +1960
===========================================
+ Hits 4951 10457 +5506
+ Misses 13194 8737 -4457
- Partials 770 1681 +911
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This seems related to #1266, we could also test if this fixes it. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ab8baac
|
@lucklove: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
When scaling cluster, tiup will check if there are directories that overlaps each other to avoid conflict. The directories include both imported an new deployed ones.
However, the components deployed by ansible will use the same directory for saving log, which is by designed. At this time, TiUP will report an error if the imported cluster share the same host with different components when you try to scale the cluster.
What is changed and how it works?
If the directories conflict are both imported, skip instead of report an error.
Check List
Tests
Code changes
Side effects
Related changes
Release notes: