-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repository: optimize error handing if root.json fails to load #1303
Conversation
60feebb
to
d899163
Compare
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
===========================================
+ Coverage 26.25% 51.32% +25.06%
===========================================
Files 263 289 +26
Lines 18947 20828 +1881
===========================================
+ Hits 4975 10690 +5715
+ Misses 13201 8426 -4775
- Partials 771 1712 +941
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d899163
|
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
===========================================
+ Coverage 26.26% 53.66% +27.40%
===========================================
Files 263 289 +26
Lines 18960 20841 +1881
===========================================
+ Hits 4980 11185 +6205
+ Misses 13207 7854 -5353
- Partials 773 1802 +1029
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
This implements the code part of #1300, document updates may still be needed.
What is changed and how it works?
Keep the original error from std libraries, and display an extra warning message if the error is failed loading
root.json
manifest, and provide an instruction for workaround (tiup mirror set
).Check List
Tests
Related changes
Release notes: